Bug 127000 – Remove unnecessary call to webGLContextCreated

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Roger Fong]

If the WebKit client hasn't implemented webGLContextCreated then we don't want to return early and we want to continue execution as usual.

This is causing 7 tests to fail which I will skip for now.
http/tests/canvas/webgl/origin-clean-conformance.html
http/tests/webgl/1.0.2/texSubImage2DHTML.html
http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
http/tests/webgl/1.0.2/texImage2DHTML.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

Note that other webgl tests aren't failing because those tests are local files, not hosted from a server like these http tests are.

[Roger Fong]

tests skipped r162002

[Roger Fong]

One way to do this would be to use a sendSync and wait for webGLContextCreated to return true or false based on whether or not we want the dialog to show up.
It will return false if the method has not implemented in the WebKit client.

Perhaps another way is upon initialization of the client, have the client send a message to webkit that sets a flag saying whether or not we need to call webGLContextCreated.

[Roger Fong]

<rdar://problem/15818843>

[Roger Fong]

I just need the default load policy to be set to allowing.
If the client does not have the method implemented then by default the returned policy will be to allow and everything will run as expected.

Keeping this bug open to land unskips

[Roger Fong]

Created attachment 221310 [details]
patch

[Roger Fong]

This patch will resolve the issue of other ports breaking.
It also will eliminate WebGLContextCreated, which means one less message to send to the UIProcess.

[Roger Fong]

O it also resolves the issue in http://trac.webkit.org/changeset/162002 where I had to skip a bunch of WebGL Http tests

[Brent Fulgham]

Comment on attachment 221310 [details]
patch

r=me

[WebKit Commit Bot]

Comment on attachment 221310 [details]
patch

Clearing flags on attachment: 221310

Committed r162099: <http://trac.webkit.org/changeset/162099>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.