Bug 126999 - [iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()
Summary: [iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary()...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-14 11:29 PST by Daniel Bates
Modified: 2014-01-14 12:55 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2014-01-14 11:32 PST, Daniel Bates
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-01-14 11:29:47 PST
We should retain the NSMutableDictionary dictionary returned by [NSMutableDictionary dictionary] in WebCore::QLPreviewConverterDictionary() and WebCore::QLContentDictionary().
Comment 1 Daniel Bates 2014-01-14 11:32:05 PST
Created attachment 221185 [details]
Patch
Comment 2 Joseph Pecoraro 2014-01-14 11:34:46 PST
Comment on attachment 221185 [details]
Patch

r=me

How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release?
Comment 3 Daniel Bates 2014-01-14 11:35:54 PST
(In reply to comment #2)
> (From update of attachment 221185 [details])
> r=me
> 
> How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release?

Will change before landing.
Comment 4 Daniel Bates 2014-01-14 12:54:02 PST
<rdar://problem/15810305>
Comment 5 Daniel Bates 2014-01-14 12:55:38 PST
Committed r161997: <http://trac.webkit.org/changeset/161997>