RESOLVED FIXED 126999
[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary() 
https://bugs.webkit.org/show_bug.cgi?id=126999
Summary [iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary()...
Daniel Bates
Reported 2014-01-14 11:29:47 PST
We should retain the NSMutableDictionary dictionary returned by [NSMutableDictionary dictionary] in WebCore::QLPreviewConverterDictionary() and WebCore::QLContentDictionary().
Attachments
Patch (1.98 KB, patch)
2014-01-14 11:32 PST, Daniel Bates 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-01-14 11:32:05 PST
Created attachment 221185 [details] Patch
Joseph Pecoraro
Comment 2 2014-01-14 11:34:46 PST
Comment on attachment 221185 [details] Patch r=me How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release?
Daniel Bates
Comment 3 2014-01-14 11:35:54 PST
(In reply to comment #2) > (From update of attachment 221185 [details]) > r=me > > How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release? Will change before landing.
Daniel Bates
Comment 4 2014-01-14 12:54:02 PST
<rdar://problem/15810305>
Daniel Bates
Comment 5 2014-01-14 12:55:38 PST
Committed r161997: <http://trac.webkit.org/changeset/161997>
Note You need to log in before you can comment on or make changes to this bug.