Bug 126983 - Remove extra includes from DFG
Summary: Remove extra includes from DFG
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 07:00 PST by Peter Molnar
Modified: 2014-12-03 03:51 PST (History)
4 users (show)

See Also:

Attachments
patch (46.10 KB, patch)
2014-01-14 07:01 PST, Peter Molnar 		kling: review-
kling: commit-queue-
Details | Formatted Diff | Diff
updated patch (46.37 KB, patch)
2014-02-10 05:49 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2014-01-14 07:00:24 PST 
Remove extra includes from DFG
Comment 1 Peter Molnar 2014-01-14 07:01:41 PST 
Created attachment 221159 [details]
patch
Comment 2 Andreas Kling 2014-02-07 02:11:11 PST 
Comment on attachment 221159 [details]
patch

This doesn't build on windows (see EWS.)
Comment 3 Peter Molnar 2014-02-10 05:48:50 PST 
(In reply to comment #2)
> (From update of attachment 221159 [details])
> This doesn't build on windows (see EWS.)

That EWS error was probably caused by the bot being red at the moment (unable to build with or without the patch...). Anyway, I'm attaching an updated patch.
Comment 4 Peter Molnar 2014-02-10 05:49:15 PST 
Created attachment 223702 [details]
updated patch
Comment 5 WebKit Commit Bot 2014-02-10 10:15:45 PST 
Comment on attachment 223702 [details]
updated patch

Clearing flags on attachment: 223702

Committed r163796: <http://trac.webkit.org/changeset/163796>
Comment 6 WebKit Commit Bot 2014-02-10 10:15:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Filip Pizlo 2014-02-10 11:15:48 PST 
I don't like changes like this.  Why are you removing #include statements?  The change is not justified either in this bug or in the changelog.  Its primary effect appears to make the code less robust against change because it only builds due to accidental transitive header dependencies.

I'm going to roll this out.  If you feel strongly about this change, you should justify why you are doing it.
Comment 8 Filip Pizlo 2014-02-10 11:21:52 PST 
Rolled out in http://trac.webkit.org/changeset/163802

If you want to make a change like this, please give a reason for it.