Bug 126978 – [CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

Return the list of fixed positioned layers sorted by z-index from FlowThreadController::collectFixedPositionedLayers instead of manually sort it every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows).

[Mihnea Ovidenie]

Created attachment 221146 [details]
Patch

[Mihai Maerean]

Comment on attachment 221146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review

> Source/WebCore/rendering/FlowThreadController.cpp:282
> +static inline bool compareZIndex(RenderLayer* first, RenderLayer* second)

Rather than having this method in both FlowThreadController and RenderLayer object files, maybe it should be a public static method of the RenderLayer class.

[Mihnea Ovidenie]

(In reply to comment #2)
> (From update of attachment 221146 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review
> 
> > Source/WebCore/rendering/FlowThreadController.cpp:282
> > +static inline bool compareZIndex(RenderLayer* first, RenderLayer* second)
> 
> Rather than having this method in both FlowThreadController and RenderLayer object files, maybe it should be a public static method of the RenderLayer class.

I thought about that but i decided not to add another method to the public interface of RenderLayer since it is just a very simple comparison function.

[Antti Koivisto]

Comment on attachment 221146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4062
>      renderer().view().flowThreadController().collectFixedPositionedLayers(fixedLayers);

Maybe call it collectSortedFixedPositionedLayers or similar?

We nowadays prefer collection functions to return the vector normally instead of passing an argument since rvalue references make it copy-free.

[WebKit Commit Bot]

Comment on attachment 221146 [details]
Patch

Clearing flags on attachment: 221146

Committed r161960: <http://trac.webkit.org/changeset/161960>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.