Bug 126959 - CStack: Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES)
Summary: CStack: Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 21:04 PST by Mark Lam
Modified: 2014-01-14 09:12 PST (History)
5 users (show)

See Also:


Attachments
the patch. (1.44 KB, patch)
2014-01-13 21:15 PST, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-01-13 21:04:18 PST
The !ENABLE(COMPUTED_GOTO_OPCODES) build of the C loop LLINT reveals the unused piece of LLINT code for sanitizeStackForVM() was still being built in.  In the computed got case, the sanitizeStackForVM() code only results in some unused code in CLoop::execute() and an extra local label which is harmless.  In the non-computed goto case, it results in a case statement for an unknown opcode named "sanitizeStackForVM".  This results in a build failure.  The fix is simply to exclude the unused LLINT sanitizeStackForVM() from the C loop build.

Patch coming.
Comment 1 Mark Lam 2014-01-13 21:15:44 PST
Created attachment 221102 [details]
the patch.
Comment 2 Mark Lam 2014-01-14 09:12:44 PST
Thanks for the review.  Landed in r161975 on the jsCStack branch: <http://trac.webkit.org/r161975>.