Bug 126955 - Web Inspector: Filter the overview graph and sidebar based on time selection
Summary: Web Inspector: Filter the overview graph and sidebar based on time selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-13 19:23 PST by Timothy Hatcher
Modified: 2014-01-20 19:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.80 KB, patch)
2014-01-13 19:27 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (10.01 KB, patch)
2014-01-13 19:46 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-13 19:23:41 PST 
The graph and sidebar rows should be filtered by the time selection.
Comment 1 Radar WebKit Bug Importer 2014-01-13 19:23:57 PST 
<rdar://problem/15811472>
Comment 2 Timothy Hatcher 2014-01-13 19:27:55 PST 
Created attachment 221096 [details]
Patch
Comment 3 Timothy Hatcher 2014-01-13 19:46:44 PST 
Created attachment 221097 [details]
Patch
Comment 4 Joseph Pecoraro 2014-01-13 23:02:04 PST 
Comment on attachment 221097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221097&action=review

r=me

> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:307
> +    applyFiltersToTreeElement: function(treeElement, dontExpandOnMatch)

I always prefer "doNotFoo" to "dontFoo".
Comment 5 Timothy Hatcher 2014-01-20 19:04:06 PST 
https://trac.webkit.org/changeset/162414