Bug 126945 - [EFL] Do not store reference variables as a pointer in private data structure
Summary: [EFL] Do not store reference variables as a pointer in private data structure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 16:20 PST by Ryuan Choi
Modified: 2014-01-13 17:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (43.04 KB, patch)
2014-01-13 16:24 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
rebased (43.25 KB, patch)
2014-01-13 16:54 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-01-13 16:20:07 PST 
Now, we stored some reference variables of WebCore as pointer variable at private data structure.
Comment 1 Ryuan Choi 2014-01-13 16:24:32 PST 
Created attachment 221085 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-13 16:28:06 PST 
Comment on attachment 221085 [details]
Patch

Looks you need to rebase.
Comment 3 Ryuan Choi 2014-01-13 16:54:02 PST 
Created attachment 221091 [details]
rebased
Comment 4 Gyuyoung Kim 2014-01-13 17:07:02 PST 
Comment on attachment 221091 [details]
rebased

LGTM
Comment 5 Ryuan Choi 2014-01-13 17:38:43 PST 
Comment on attachment 221091 [details]
rebased

Clearing flags on attachment: 221091

Committed r161933: <http://trac.webkit.org/changeset/161933>
Comment 6 Ryuan Choi 2014-01-13 17:38:51 PST 
All reviewed patches have been landed.  Closing bug.