Bug 126936 - [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build
Summary: [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 15:17 PST by Andy Estes
Modified: 2014-01-13 16:30 PST (History)
7 users (show)

See Also:

Attachments
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build (18.04 KB, patch)
2014-01-13 15:44 PST, Andy Estes 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-01-13 15:17:05 PST 
[iOS] Exclude Shims and PluginProcess.app from the WebKit2 build
Comment 1 Andy Estes 2014-01-13 15:44:15 PST 
Created attachment 221083 [details]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
Comment 2 Daniel Bates 2014-01-13 15:55:23 PST 
Comment on attachment 221083 [details]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build

View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review

Looks sane to me. Feel free to ask a build system expert for a more thorough review.

> Source/WebKit2/Configurations/Shim.xcconfig:33
> +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore;
> +OTHER_LDFLAGS_SecItemShim = -framework Security;
> +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security;

I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables.
Comment 3 Andy Estes 2014-01-13 16:29:41 PST 
Committed r161918: <http://trac.webkit.org/changeset/161918>
Comment 4 Andy Estes 2014-01-13 16:30:27 PST 
(In reply to comment #2)
> (From update of attachment 221083 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review
> 
> Looks sane to me. Feel free to ask a build system expert for a more thorough review.
> 
> > Source/WebKit2/Configurations/Shim.xcconfig:33
> > +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore;
> > +OTHER_LDFLAGS_SecItemShim = -framework Security;
> > +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security;
> 
> I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables.

Per a recommendation from mitzpettel, I ended up creating new .xcconfigs for each of the shims and moving these options there.