Bug 126936 – [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Exclude Shims and PluginProcess.app from the WebKit2 build

[Andy Estes]

Created attachment 221083 [details]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build

[Daniel Bates]

Comment on attachment 221083 [details]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build

View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review

Looks sane to me. Feel free to ask a build system expert for a more thorough review.

> Source/WebKit2/Configurations/Shim.xcconfig:33
> +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore;
> +OTHER_LDFLAGS_SecItemShim = -framework Security;
> +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security;

I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables.

[Andy Estes]

Committed r161918: <http://trac.webkit.org/changeset/161918>

[Andy Estes]

(In reply to comment #2)
> (From update of attachment 221083 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review
> 
> Looks sane to me. Feel free to ask a build system expert for a more thorough review.
> 
> > Source/WebKit2/Configurations/Shim.xcconfig:33
> > +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon -framework QuartzCore;
> > +OTHER_LDFLAGS_SecItemShim = -framework Security;
> > +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security;
> 
> I take it you feel that it wouldn't improve readability to include _macosx_ in the names of these variables.

Per a recommendation from mitzpettel, I ended up creating new .xcconfigs for each of the shims and moving these options there.