Bug 126933 - Update WebPageProxyIOS's user agent string
Summary: Update WebPageProxyIOS's user agent string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 14:50 PST by Benjamin Poulain
Modified: 2014-01-13 19:48 PST (History)
0 users

See Also:

Attachments
Patch (1.83 KB, patch)
2014-01-13 14:51 PST, Benjamin Poulain 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-01-13 14:50:06 PST 
Update WebPageProxyIOS's user agent string
Comment 1 Benjamin Poulain 2014-01-13 14:51:08 PST 
Created attachment 221080 [details]
Patch
Comment 2 Darin Adler 2014-01-13 16:50:06 PST 
Comment on attachment 221080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51
> +        return (NSString *)overrideUserAgent;

I think you can remove that typecast.
Comment 3 Benjamin Poulain 2014-01-13 19:39:21 PST 
(In reply to comment #2)
> (From update of attachment 221080 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review
> 
> > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51
> > +        return (NSString *)overrideUserAgent;
> 
> I think you can remove that typecast.

Good catch.
Comment 4 Benjamin Poulain 2014-01-13 19:48:51 PST 
Committed r161940: <http://trac.webkit.org/changeset/161940>