WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126933
Update WebPageProxyIOS's user agent string
https://bugs.webkit.org/show_bug.cgi?id=126933
Summary
Update WebPageProxyIOS's user agent string
Benjamin Poulain
Reported
2014-01-13 14:50:06 PST
Update WebPageProxyIOS's user agent string
Attachments
Patch
(1.83 KB, patch)
2014-01-13 14:51 PST
,
Benjamin Poulain
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-01-13 14:51:08 PST
Created
attachment 221080
[details]
Patch
Darin Adler
Comment 2
2014-01-13 16:50:06 PST
Comment on
attachment 221080
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=221080&action=review
> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > + return (NSString *)overrideUserAgent;
I think you can remove that typecast.
Benjamin Poulain
Comment 3
2014-01-13 19:39:21 PST
(In reply to
comment #2
)
> (From update of
attachment 221080
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=221080&action=review
> > > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > > + return (NSString *)overrideUserAgent; > > I think you can remove that typecast.
Good catch.
Benjamin Poulain
Comment 4
2014-01-13 19:48:51 PST
Committed
r161940
: <
http://trac.webkit.org/changeset/161940
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug