RESOLVED FIXED 126925
[WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel 
https://bugs.webkit.org/show_bug.cgi?id=126925
Summary [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
Brent Fulgham
Reported 2014-01-13 12:21:16 PST
The existing logic for texture level checking in WebGLRenderingContext::validateTexFuncLevel had an off-by-one error. It ensured that we never exceeded the value of "m_maxTextureLevel" (or "m_maxCubeMapTextureLevel"). However, these values mark the upper bound of the texture level; the storage is sized to hold this count of entries, but the actual levels are 0-indexed.
Attachments
Patch (66.53 KB, patch)
2014-01-13 13:49 PST, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-01-13 13:49:54 PST
Created attachment 221078 [details] Patch
Brent Fulgham
Comment 2 2014-01-13 14:23:12 PST
Committed r161907: <http://trac.webkit.org/changeset/161907>
Alexey Proskuryakov
Comment 3 2014-01-13 21:44:25 PST
fast/canvas/webgl/webgl-compressed-texture-size-limit.html fails on all Mountain Lion bots, and is flaky on Mavericks. Brent, are you available to look into this now?
WebKit Commit Bot
Comment 4 2014-01-13 21:56:33 PST
Re-opened since this is blocked by bug 126963
Brent Fulgham
Comment 6 2014-01-13 23:58:45 PST
(In reply to comment #3) > fast/canvas/webgl/webgl-compressed-texture-size-limit.html fails on all Mountain Lion bots, and is flaky on Mavericks. > > Brent, are you available to look into this now? Crap. It's graphics-card specific.
Brent Fulgham
Comment 7 2014-01-14 09:48:47 PST
Revising tests to limit texture memory to 8196, to match our smallest test bots.
Brent Fulgham
Comment 8 2014-01-14 09:49:10 PST
Committed r161978: <http://trac.webkit.org/changeset/161978>
Alexey Proskuryakov
Comment 9 2014-01-14 10:24:08 PST
This test is now crashing on bots (at least some, most haven't caught up yet): http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r161978%20(2387)/fast/canvas/webgl/webgl-compressed-texture-size-limit-crash-log.txt
WebKit Commit Bot
Comment 10 2014-01-14 10:31:58 PST
Re-opened since this is blocked by bug 126992
Brent Fulgham
Comment 11 2014-01-14 12:48:44 PST
Committed r161996: <http://trac.webkit.org/changeset/161996>
Radar WebKit Bug Importer
Comment 12 2014-01-14 14:08:20 PST
<rdar://problem/15818236>
Note You need to log in before you can comment on or make changes to this bug.