Bug 126924 – Add uint8_t specialization for WebCore::writeLittleEndian()

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Daniel Bates]

When I ran Tools/Scripts/build-webkit --debug --device, the build failed to compile SerializedScriptValue.cpp with the following error:
 
/OpenSource/Source/WebCore/bindings/js/SerializedScriptValue.cpp:421:19: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
/OpenSource/Source/WebCore/bindings/js/SerializedScriptValue.cpp:967:9: note: in instantiation of function template specialization 'WebCore::writeLittleEndian<unsigned char>' requested here
1 error generated.

[Daniel Bates]

Created attachment 221069 [details]
Patch

[Darin Adler]

Comment on attachment 221069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221069&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:431
> +    if (length > std::numeric_limits<uint32_t>::max())
> +        return false;

This can’t happen. A uint32_t can’t be higher than the maximum.

[Daniel Bates]

Created attachment 221070 [details]
Patch

[Daniel Bates]

(In reply to comment #2)
> (From update of attachment 221069 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221069&action=review
> 
> > Source/WebCore/bindings/js/SerializedScriptValue.cpp:431
> > +    if (length > std::numeric_limits<uint32_t>::max())
> > +        return false;
> 
> This can’t happen. A uint32_t can’t be higher than the maximum.

You're right! I removed this conditional.

[Daniel Bates]

Committed r161903: <http://trac.webkit.org/changeset/161903>