RESOLVED FIXED126917
Map RootInlineBox to containing region via bit+hashmap. 
https://bugs.webkit.org/show_bug.cgi?id=126917
Summary Map RootInlineBox to containing region via bit+hashmap.
Andreas Kling
Reported 2014-01-13 10:43:13 PST
Map RootInlineBox to containing region via bit+hashmap.
Attachments
Patch (6.53 KB, patch)
2014-01-13 10:46 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Moon lander (7.73 KB, patch)
2014-01-13 11:49 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-01-13 10:46:27 PST
Created attachment 221062 [details] Patch
Antti Koivisto
Comment 2 2014-01-13 10:53:10 PST
Comment on attachment 221062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221062&action=review > Source/WebCore/rendering/RootInlineBox.cpp:279 > void RootInlineBox::setContainingRegion(RenderRegion* region) > { > ASSERT(!isDirty()); > ASSERT(blockFlow().flowThreadContainingBlock()); > - m_containingRegion = region; > + > + if (!region && !m_hasContainingRegion) > + return; > + > + if (region) > + containingRegionMap().set(this, region); > + else > + containingRegionMap().remove(this); > + > + m_hasContainingRegion = !!region; > } It would be nicer to have setContainingRegion(RenderRegion&) and clearContainingRegion() separately.
Andreas Kling
Comment 3 2014-01-13 11:49:31 PST
Created attachment 221067 [details] Moon lander
WebKit Commit Bot
Comment 4 2014-01-13 14:29:04 PST
Comment on attachment 221067 [details] Moon lander Clearing flags on attachment: 221067 Committed r161909: <http://trac.webkit.org/changeset/161909>
WebKit Commit Bot
Comment 5 2014-01-13 14:29:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.