Bug 126916 - r161638 broke the Windows build
Summary: r161638 broke the Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126698
  Show dependency tree / graph
 
Reported: 2014-01-13 10:11 PST by Csaba Osztrogonác
Modified: 2014-01-13 12:33 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-01-13 10:11:03 PST 
Apple Windows build is broken after a clean build triggered with the following error:

     1>c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\bindings\js\JSDocumentCustom.cpp(34): fatal error C1083: Cannot open include file: 'JSTouch.h': No such file or directory (..\bindings\js\JSBindingsAllInOne.cpp)
Comment 1 Csaba Osztrogonác 2014-01-13 10:32:00 PST 
The culprit is between r161565 - r161638, because Touch.idl was
processed at r161565, but not on r161638.

I assume r161638 is the culprit.
Comment 2 Csaba Osztrogonác 2014-01-13 10:42:31 PST 
fix is coming
Comment 3 Csaba Osztrogonác 2014-01-13 10:55:46 PST 
(In reply to comment #2)
> fix is coming

As I mentioned in https://bugs.webkit.org/show_bug.cgi?id=126698#c15
the mentioned idl files should be added for non IOS platforms, but
after r161638 they are added if MACOS and !IOS.

I don't have Windows to validate a fix and Windows EWS bots are out
of order, so I'm not going to fix it blindly with GNU makefile magic.
Feel free to pick it up.
Comment 4 Csaba Osztrogonác 2014-01-13 12:33:59 PST 
Fixed in http://trac.webkit.org/changeset/161901