Bug 126901 - Performance regression on dromaeo due to generational marking
Summary: Performance regression on dromaeo due to generational marking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
: 126902 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-13 07:49 PST by Mark Hahnenberg
Modified: 2015-10-06 18:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.56 KB, patch)
2014-01-13 12:58 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-01-13 07:49:49 PST 
Generational marking is off in ToT, but some of the machinery to make it work isn't fully disabled which is causing regressions on dromaeo. We should disable more things to get to a point where the patch is no regression when ENABLE_GGC == 0 because it would be nice to have the option to disable generational collection for diagnosing any potential GGC bugs.
Comment 1 Mark Hahnenberg 2014-01-13 12:58:26 PST 
Created attachment 221075 [details]
Patch
Comment 2 Mark Hahnenberg 2014-01-13 15:11:52 PST 
I ran dromaeo and it looks like this patch fixes the obvious regressions.
Comment 3 WebKit Commit Bot 2014-01-13 15:46:51 PST 
Comment on attachment 221075 [details]
Patch

Clearing flags on attachment: 221075

Committed r161914: <http://trac.webkit.org/changeset/161914>
Comment 4 WebKit Commit Bot 2014-01-13 15:46:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2015-10-06 18:21:09 PDT 
*** Bug 126902 has been marked as a duplicate of this bug. ***