Bug 126886 – [CSS Regions] Hit-testing goes through clipped layer in fast/regions/overflow-first-and-last-regions-in-container-hidden.html

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrei Bucur]

If you move the cursor above the orange rectangles (that clip) of the left side tests of fast/regions/overflow-first-and-last-regions-in-container-hidden.html, the cursor changes to a text selection icon. This means the text inside the regions that was clipped out actually is detected by the hit-test algorithm.

[Andrei Bucur]

Created attachment 221060 [details]
Patch

[Mihnea Ovidenie]

Comment on attachment 221060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221060&action=review

r=me with some comments

> Source/WebCore/ChangeLog:10
> +        flow thread. The patch verifies the location is inside the clipping rectangle of the region before

"the location" - > "that the location"

> Source/WebCore/rendering/RenderLayer.cpp:7015
> +        ClipRectsContext clipRectsContext(rootLayer, hitTestLocation.region(), TemporaryClipRects, IgnoreOverlayScrollbarSize);

You do not need to specify the last param - IgnoreOverlayScrollbarSize - as it is the default value in ctor.

> LayoutTests/fast/regions/hover-and-js-in-visual-overflow-hidden.html:80
> +        <li>Move the mouse under the gray rectangle.</li>

"under" -> "below". I found under confusing in this context.

[Andrei Bucur]

Created attachment 221236 [details]
Patch

[Mihnea Ovidenie]

Comment on attachment 221236 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 221236 [details]
Patch

Clearing flags on attachment: 221236

Committed r162064: <http://trac.webkit.org/changeset/162064>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.