Bug 126882 - [EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
Summary: [EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 04:27 PST by Jinwoo Song
Modified: 2014-01-13 15:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2014-01-13 04:29 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2014-01-13 07:04 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-13 04:27:25 PST 
SSIA.
Comment 1 Jinwoo Song 2014-01-13 04:29:01 PST 
Created attachment 221028 [details]
Patch
Comment 2 Sergio Correia (qrwteyrutiyoup) 2014-01-13 04:32:26 PST 
Comment on attachment 221028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221028&action=review

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:66
> +    static NeverDestroyed<String> webKitWebProcessName(findProcessPath(WEBPROCESSNAME));

NeverDestroyed<const String> here?

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:73
> +    static NeverDestroyed<String> webKitPluginProcessName(findProcessPath(PLUGINPROCESSNAME));

Ditto.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:81
> +    static NeverDestroyed<String> webKitNetworkProcessName(findProcessPath(NETWORKPROCESSNAME));

Ditto.
Comment 3 Jinwoo Song 2014-01-13 07:04:53 PST 
Created attachment 221038 [details]
Patch
Comment 4 Jinwoo Song 2014-01-13 07:05:24 PST 
Comment on attachment 221028 [details]
Patch

done!
Comment 5 WebKit Commit Bot 2014-01-13 15:58:47 PST 
Comment on attachment 221038 [details]
Patch

Clearing flags on attachment: 221038

Committed r161915: <http://trac.webkit.org/changeset/161915>
Comment 6 WebKit Commit Bot 2014-01-13 15:58:51 PST 
All reviewed patches have been landed.  Closing bug.