Bug 126881 - [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
Summary: [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 02:57 PST by Adrian Perez
Modified: 2014-01-13 03:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2014-01-13 02:59 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2014-01-13 03:11 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2014-01-13 02:57:19 PST 
[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
Comment 1 Adrian Perez 2014-01-13 02:59:44 PST 
Created attachment 221021 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-01-13 03:04:47 PST 
Comment on attachment 221021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221021&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:710
> -        g_object_add_weak_pointer(G_OBJECT(parent), &window->parentWindow);
> +        g_object_add_weak_pointer(G_OBJECT(parent), (gpointer*) &window->parentWindow);

Add a space between the gpointer and the * and remove the space between the parentheses and the &

g_object_add_weak_pointer(G_OBJECT(parent), (gpointer *)&window->parentWindow);
Comment 3 Adrian Perez 2014-01-13 03:11:36 PST 
Created attachment 221023 [details]
Patch
Comment 4 WebKit Commit Bot 2014-01-13 03:46:51 PST 
Comment on attachment 221023 [details]
Patch

Clearing flags on attachment: 221023

Committed r161875: <http://trac.webkit.org/changeset/161875>
Comment 5 WebKit Commit Bot 2014-01-13 03:46:52 PST 
All reviewed patches have been landed.  Closing bug.