Bug 126873 - REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
Summary: REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 00:19 PST by Alexey Proskuryakov
Modified: 2014-01-13 08:11 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2014-01-13 07:29 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-13 00:19:34 PST 
WebKit bindings tests complain about uninitialized PLATFORM_NAME a lot, see e.g. <https://webkit-queues.appspot.com/results/6110151471792128>:

Running bindings generation tests
Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63.

PASS: (JS) JSTestCallback.cpp
PASS: (JS) JSTestCallback.h
Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63.

PASS: (JS) JSTestCustomNamedGetter.cpp
PASS: (JS) JSTestCustomNamedGetter.h
Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63.

PASS: (JS) JSTestActiveDOMObject.cpp
PASS: (JS) JSTestActiveDOMObject.h
Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63.
Comment 1 Tibor Mészáros 2014-01-13 07:29:32 PST 
Created attachment 221039 [details]
Patch

Now checked that the $ENV{"PLATFORM_NAME"} is defined or not.
Comment 2 WebKit Commit Bot 2014-01-13 08:11:39 PST 
Comment on attachment 221039 [details]
Patch

Clearing flags on attachment: 221039

Committed r161878: <http://trac.webkit.org/changeset/161878>
Comment 3 WebKit Commit Bot 2014-01-13 08:11:44 PST 
All reviewed patches have been landed.  Closing bug.