Bug 126867 - Fix build warnings by unused parameter
Summary: Fix build warnings by unused parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-12 19:46 PST by Jinwoo Song
Modified: 2014-01-12 22:14 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2014-01-12 20:49 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-12 19:46:56 PST 
In file included from /home/jinwoo/opensource/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:37:0:
/home/jinwoo/opensource/WebKit/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h:151:40: warning: unused parameter ‘checkingTypes’ [-Wunused-parameter]
     virtual Vector<TextCheckingResult> checkTextOfParagraph(StringView, TextCheckingTypeMask checkingTypes) { return Vector<TextCheckingResult>(); }

/home/jinwoo/opensource/WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:558:6: warning: unused parameter ‘operation’ [-Wunused-parameter]
 void IDBServerConnectionLevelDB::changeDatabaseVersion(IDBTransactionBackend& transaction, const IDBDatabaseBackend::VersionChangeOperation& operation, std::function<void(PassRefPtr<IDBDatabaseError>)> completionCallback)
Comment 1 Jinwoo Song 2014-01-12 20:49:31 PST 
Created attachment 221001 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-12 21:43:23 PST 
Comment on attachment 221001 [details]
Patch

In this case, I think variable type isn't primitive. Thus, we're able to know the meaning of removing parameters after this patch. Looks fine.
Comment 3 WebKit Commit Bot 2014-01-12 22:14:08 PST 
Comment on attachment 221001 [details]
Patch

Clearing flags on attachment: 221001

Committed r161860: <http://trac.webkit.org/changeset/161860>
Comment 4 WebKit Commit Bot 2014-01-12 22:14:12 PST 
All reviewed patches have been landed.  Closing bug.