WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126861
Remove all uses of AtomicallyInitializedStatic from WebCore
https://bugs.webkit.org/show_bug.cgi?id=126861
Summary
Remove all uses of AtomicallyInitializedStatic from WebCore
Anders Carlsson
Reported
2014-01-12 17:53:18 PST
Remove all uses of AtomicallyInitializedStatic from WebCore
Attachments
Patch
(7.23 KB, patch)
2014-01-12 17:54 PST
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-12 17:54:06 PST
Created
attachment 220993
[details]
Patch
Darin Adler
Comment 2
2014-01-12 17:55:16 PST
Comment on
attachment 220993
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220993&action=review
> Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:47 > + transactions = new ThreadSpecific<TransactionList>();
No need for the "()" here.
> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:84 > + map = new ThreadSpecific<BlobUrlOriginMap>();
Ditto.
WebKit Commit Bot
Comment 3
2014-01-12 17:56:33 PST
Attachment 220993
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp', u'Source/WebCore/fileapi/ThreadableBlobRegistry.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:46: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/workers/DefaultSharedWorkerRepository.cpp:346: Missing space before { [whitespace/braces] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4
2014-01-12 17:57:45 PST
Committed
r161847
: <
http://trac.webkit.org/changeset/161847
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug