Bug 126861 - Remove all uses of AtomicallyInitializedStatic from WebCore
Summary: Remove all uses of AtomicallyInitializedStatic from WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-12 17:53 PST by Anders Carlsson
Modified: 2014-01-12 17:57 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.23 KB, patch)
2014-01-12 17:54 PST, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-12 17:53:18 PST 
Remove all uses of AtomicallyInitializedStatic from WebCore
Comment 1 Anders Carlsson 2014-01-12 17:54:06 PST 
Created attachment 220993 [details]
Patch
Comment 2 Darin Adler 2014-01-12 17:55:16 PST 
Comment on attachment 220993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220993&action=review

> Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:47
> +        transactions = new ThreadSpecific<TransactionList>();

No need for the "()" here.

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:84
> +        map = new ThreadSpecific<BlobUrlOriginMap>();

Ditto.
Comment 3 WebKit Commit Bot 2014-01-12 17:56:33 PST 
Attachment 220993 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp', u'Source/WebCore/fileapi/ThreadableBlobRegistry.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:46:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:83:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/workers/DefaultSharedWorkerRepository.cpp:346:  Missing space before {  [whitespace/braces] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-01-12 17:57:45 PST 
Committed r161847: <http://trac.webkit.org/changeset/161847>