WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126850
Clean up NetworkStateNotifier class
https://bugs.webkit.org/show_bug.cgi?id=126850
Summary
Clean up NetworkStateNotifier class
Anders Carlsson
Reported
2014-01-12 12:39:41 PST
Clean up NetworkStateNotifier class
Attachments
Patch
(3.58 KB, patch)
2014-01-12 12:40 PST
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-12 12:40:47 PST
Created
attachment 220981
[details]
Patch
WebKit Commit Bot
Comment 2
2014-01-12 12:41:39 PST
Attachment 220981
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/NetworkStateNotifier.cpp', u'Source/WebCore/platform/network/NetworkStateNotifier.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:40: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:47: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2014-01-12 12:55:23 PST
Committed
r161830
: <
http://trac.webkit.org/changeset/161830
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug