Bug 126845 - Web Inspector: add test for hitting breakpoints from functions called via console
Summary: Web Inspector: add test for hitting breakpoints from functions called via con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-12 10:33 PST by BJ Burg
Modified: 2014-02-11 14:57 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2014-02-10 07:28 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-01-12 10:33:16 PST 
This is to prevent regression of https://bugs.webkit.org/show_bug.cgi?id=10214
Comment 1 Radar WebKit Bug Importer 2014-01-12 10:33:32 PST 
<rdar://problem/15801029>
Comment 2 Diego Pino 2014-02-10 07:28:51 PST 
Created attachment 223710 [details]
Patch
Comment 3 WebKit Commit Bot 2014-02-10 13:32:23 PST 
Comment on attachment 223710 [details]
Patch

Clearing flags on attachment: 223710

Committed r163811: <http://trac.webkit.org/changeset/163811>
Comment 4 WebKit Commit Bot 2014-02-10 13:32:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2014-02-10 14:01:00 PST 
Comment on attachment 223710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223710&action=review

> LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html:23
> +                // Shoul hit breakpoint (a > 10).

Typo: "Shoul" => "Should"
Comment 6 Diego Pino 2014-02-11 14:57:35 PST 
Fixed typo in http://trac.webkit.org/changeset/163911. Thanks.