Bug 126831 - Web Inspector: Implement bar graph rendering for OverviewTimelineView
Summary: Web Inspector: Implement bar graph rendering for OverviewTimelineView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-11 19:51 PST by Timothy Hatcher
Modified: 2014-01-20 19:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (39.38 KB, patch)
2014-01-11 20:06 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Screenshot (694.67 KB, image/png)
2014-01-11 20:09 PST, Timothy Hatcher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-11 19:51:31 PST 
The rendering for resources and source code timelines needs implemented.
Comment 1 Radar WebKit Bug Importer 2014-01-11 19:51:42 PST 
<rdar://problem/15800345>
Comment 2 Timothy Hatcher 2014-01-11 20:06:23 PST 
Created attachment 220952 [details]
Patch
Comment 3 Timothy Hatcher 2014-01-11 20:09:39 PST 
Created attachment 220953 [details]
Screenshot
Comment 4 Joseph Pecoraro 2014-01-17 11:48:17 PST 
Comment on attachment 220952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220952&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:98
> +            } else {
> +                timelineRecordBar.element.remove();
> +            }

Style: Braces not needed.

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:86
> +        // If this bar is completly after the current time, return early.

Typo: completly

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:90
> +        // If this bar is completly before or after the bounds of the graph, return early.

Typo: completly
Comment 5 Timothy Hatcher 2014-01-20 19:03:33 PST 
https://trac.webkit.org/changeset/162412