Bug 126828 - Web Inspector: protocol generator should support integer-typed declarations
Summary: Web Inspector: protocol generator should support integer-typed declarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-11 18:40 PST by BJ Burg
Modified: 2014-01-13 12:06 PST (History)
6 users (show)

See Also:

Attachments
patch (7.46 KB, patch)
2014-01-11 21:01 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
New generated type builder - includes typedef BreakpointActionIdentifier (47.44 KB, text/plain)
2014-01-12 15:19 PST, BJ Burg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-01-11 18:40:42 PST 
If you edit Runtime.json, the inspector code generator does not re-run (or at least, the files that ScriptDebugServer/etc in WebCore sees are stale).
Comment 1 Radar WebKit Bug Importer 2014-01-11 18:40:59 PST 
<rdar://problem/15800306>
Comment 2 BJ Burg 2014-01-11 19:15:30 PST 
Disregard the previous comment; it seems the code generator was simply ignoring an added type, make it appear to be stale.
Comment 3 BJ Burg 2014-01-11 21:01:51 PST 
Created attachment 220954 [details]
patch
Comment 4 EFL EWS Bot 2014-01-12 05:16:43 PST 
Comment on attachment 220954 [details]
patch

Attachment 220954 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/4554984884535296
Comment 5 BJ Burg 2014-01-12 14:08:50 PST 
The EFL failure is an unrelated ICE on Document.cpp
Comment 6 BJ Burg 2014-01-12 15:19:22 PST 
Created attachment 220986 [details]
New generated type builder - includes typedef BreakpointActionIdentifier
Comment 7 Joseph Pecoraro 2014-01-13 10:49:48 PST 
Comment on attachment 220954 [details]
patch

r=me
Comment 8 BJ Burg 2014-01-13 12:06:11 PST 
Comment on attachment 220954 [details]
patch

Clearing flags on attachment: 220954

Committed r161900: <http://trac.webkit.org/changeset/161900>
Comment 9 BJ Burg 2014-01-13 12:06:14 PST 
All reviewed patches have been landed.  Closing bug.