Bug 126819 - ScriptDebugServer should use a separate member function for its timer handler
Summary: ScriptDebugServer should use a separate member function for its timer handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-11 11:16 PST by Anders Carlsson
Modified: 2014-01-11 13:44 PST (History)
0 users

See Also:

Attachments
Patch (6.79 KB, patch)
2014-01-11 11:17 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-11 11:16:30 PST 
ScriptDebugServer should use a separate member function for its timer handler
Comment 1 Anders Carlsson 2014-01-11 11:17:50 PST 
Created attachment 220940 [details]
Patch
Comment 2 Anders Carlsson 2014-01-11 11:27:24 PST 
Committed r161771: <http://trac.webkit.org/changeset/161771>
Comment 3 Joseph Pecoraro 2014-01-11 13:44:33 PST 
Comment on attachment 220940 [details]
Patch

Although I don't disagree with the change. What is the reason why here?

In any case, we want to remove the Timer, since this will need to be pushed down into JavaScriptCore soon anyways (which doesn't have a platform/Timer and we should be able to avoid it).