Bug 126815 - [Mac] xcodebuild color output is suppressed when using make
Summary: [Mac] xcodebuild color output is suppressed when using make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-11 10:13 PST by mitz
Modified: 2014-06-03 23:07 PDT (History)
1 user (show)

See Also:

Attachments
Pass COLOR_DIAGNOSTICS=YES to xcodebuild (1.33 KB, patch)
2014-01-11 10:16 PST, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-01-11 10:13:15 PST 
When using make to build WebKit, xcodebuild’s output is piped through a filter, which causes it not to format its output with color and emphasis.
Comment 1 mitz 2014-01-11 10:16:14 PST 
Created attachment 220936 [details]
Pass COLOR_DIAGNOSTICS=YES to xcodebuild
Comment 2 mitz 2014-01-11 11:44:19 PST 
Fixed (to the extent possible) in <http://trac.webkit.org/r161772>.
Comment 3 Simon Fraser (smfr) 2014-06-03 15:35:18 PDT 
This caused a "make d" in Source/WebCore to do a  full rebuild because its environment has COLOR_DIAGNOSTICS=NO
Comment 4 mitz 2014-06-03 22:08:43 PDT 
(In reply to comment #3)
> This caused a "make d" in Source/WebCore to do a  full rebuild because its environment has COLOR_DIAGNOSTICS=NO

Is this something specific to WebCore? When I try this in Source/WTF I see COLOR_DIAGNOSTICS being set to YES when using make and to NO when building in the Xcode IDE, but alternating between the two doesn’t cause any files to recompile. I’m using Xcode 5.1.
Comment 5 Simon Fraser (smfr) 2014-06-03 22:59:36 PDT 
This may depend on the Xcode version. I've only noticed this rebuilding issue fairly recently.
Comment 6 mitz 2014-06-03 23:07:58 PDT 
(In reply to comment #5)
> This may depend on the Xcode version. I've only noticed this rebuilding issue fairly recently.

Just using xcodebuild from the command line (without piping through a filter) results in COLOR_DIAGNOSTICS being set to YES, whereas building from the IDE sets it to NO. If this difference alone causes some version of Xcode to rebuild everything, then it’s an issue with global impact, not affecting only WebKit.