Bug 126814 - CTTE Timer and DeferrableOneShotTimer
Summary: CTTE Timer and DeferrableOneShotTimer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-11 10:03 PST by Anders Carlsson
Modified: 2014-01-11 10:16 PST (History)
1 user (show)

See Also:

Attachments
Patch (121.32 KB, patch)
2014-01-11 10:07 PST, Anders Carlsson 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-11 10:03:43 PST 
CTTE Timer and DeferrableOneShotTimer
Comment 1 Anders Carlsson 2014-01-11 10:07:52 PST 
Created attachment 220935 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-11 10:10:31 PST 
Attachment 220935 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/geolocation/Geolocation.cpp', u'Source/WebCore/Modules/geolocation/Geolocation.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h', u'Source/WebCore/Modules/mediasource/SourceBuffer.cpp', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/notifications/NotificationCenter.cpp', u'Source/WebCore/Modules/notifications/NotificationCenter.h', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AXObjectCache.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/css/CSSImageGeneratorValue.cpp', u'Source/WebCore/css/CSSImageGeneratorValue.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/EventSender.h', u'Source/WebCore/dom/GenericEventQueue.cpp', u'Source/WebCore/dom/GenericEventQueue.h', u'Source/WebCore/dom/ScriptRunner.cpp', u'Source/WebCore/dom/ScriptRunner.h', u'Source/WebCore/dom/ScriptedAnimationController.cpp', u'Source/WebCore/dom/ScriptedAnimationController.h', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/AlternativeTextController.h', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/FrameSelection.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/html/HTMLSourceElement.cpp', u'Source/WebCore/html/HTMLSourceElement.h', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/HTMLTrackElement.h', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/MediaDocument.h', u'Source/WebCore/html/parser/HTMLParserScheduler.cpp', u'Source/WebCore/html/parser/HTMLParserScheduler.h', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.h', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControls.h', u'Source/WebCore/html/track/LoadableTextTrack.cpp', u'Source/WebCore/html/track/LoadableTextTrack.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/loader/DocumentLoader.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.cpp', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/NavigationScheduler.h', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PingLoader.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/ProgressTracker.h', u'Source/WebCore/loader/ResourceLoadScheduler.cpp', u'Source/WebCore/loader/ResourceLoadScheduler.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResource.h', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/IconDatabase.h', u'Source/WebCore/page/AutoscrollController.cpp', u'Source/WebCore/page/AutoscrollController.h', u'Source/WebCore/page/CaptionUserPreferences.cpp', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/DeviceController.cpp', u'Source/WebCore/page/DeviceController.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/EventSource.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/PageThrottler.h', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/AnimationControllerPrivate.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerPool.h', u'Source/WebCore/platform/graphics/ca/mac/LayerPool.mm', u'Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h', u'Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.cpp', u'Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h', u'Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h', u'Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm', u'Source/WebCore/platform/mac/ScrollAnimatorMac.h', u'Source/WebCore/platform/mac/ScrollAnimatorMac.mm', u'Source/WebCore/platform/mock/DeviceOrientationClientMock.cpp', u'Source/WebCore/platform/mock/DeviceOrientationClientMock.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/ImageQualityController.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMarquee.h', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/Modules/geolocation/Geolocation.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 133 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2014-01-11 10:10:47 PST 
Comment on attachment 220935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220935&action=review

> Source/WebCore/platform/Timer.h:142
> +    DeprecatedTimerFiredFunction m_deprecatedFunction;

Would be good to add a brief FIXME mentioning what this is about.
Comment 4 Anders Carlsson 2014-01-11 10:15:00 PST 
Committed r161768: <http://trac.webkit.org/changeset/161768>
Comment 5 Antti Koivisto 2014-01-11 10:16:55 PST 
Comment on attachment 220935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220935&action=review

> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:99
> -    void taskTimerFired(Timer<IDBTransactionBackend>*);
> +    void taskTimerFired(Timer<IDBTransactionBackend>&);

Maybe we can get rid of the whole timer argument as it is basically never used for anything substantive.