[Win] Application name in user agent string is truncated.

The application name part of the user agent string is cut off after the first letter.

We need to make the application name string 8 bit.

Created attachment 220924 [details]
Patch

Created attachment 220925 [details]
Patch

[Anders Carlsson]

Comment on attachment 220925 [details]
Patch

This won't work if the application name contains 16-bit characters. Maybe something in the network layer is wrong?

[Brent Fulgham]

Comment on attachment 220925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220925&action=review

> Source/WebKit/win/WebView.cpp:3186
> +    m_applicationName = String::make8BitFrom16BitSource(applicationName16.characters16(), applicationName16.length());

Maybe this should just be applicationName16.utf8().data().

Created attachment 220945 [details]
Patch

(In reply to comment #4)
> (From update of attachment 220925 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220925&action=review
> 
> > Source/WebKit/win/WebView.cpp:3186
> > +    m_applicationName = String::make8BitFrom16BitSource(applicationName16.characters16(), applicationName16.length());
> 
> Maybe this should just be applicationName16.utf8().data().

Thanks for looking into this, guys :) Updated patch according to comments.

[Anders Carlsson]

Comment on attachment 220945 [details]
Patch

I don't think this is quite right either. m_applicationName is already Unicode encoded.

Created attachment 221042 [details]
Patch

(In reply to comment #8)
> Created an attachment (id=221042) [details]
> Patch

Updated patch, the root of the problem seems to be a missing 8-bit check in the string concatenation.

[WebKit Commit Bot]

Comment on attachment 221042 [details]
Patch

Clearing flags on attachment: 221042

Committed r161983: <http://trac.webkit.org/changeset/161983>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.