WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126792
Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792
Summary
Fix CharsetData.cpp build for iOS
Simon Fraser (smfr)
Reported
2014-01-10 16:29:29 PST
Fix CharsetData.cpp build for iOS
Attachments
Patch
(4.49 KB, patch)
2014-01-10 16:31 PST
,
Simon Fraser (smfr)
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-01-10 16:31:17 PST
Created
attachment 220905
[details]
Patch
Mark Rowe (bdash)
Comment 2
2014-01-10 16:34:51 PST
Comment on
attachment 220905
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220905&action=review
r=me
> Source/WebCore/DerivedSources.make:1194 > +ifeq ($(WTF_PLATFORM_IOS),1) > + > +CharsetData.cpp : platform/text/mac/make-charset-table.pl platform/text/mac/character-sets.txt platform/text/mac/ios-encodings.txt > + perl $^ kTextEncoding > $@ > + > +else > + > CharsetData.cpp : platform/text/mac/make-charset-table.pl platform/text/mac/character-sets.txt platform/text/mac/mac-encodings.txt > perl $^ kTextEncoding > $@ > > +endif # WTF_PLATFORM_IOS
Can we avoid some of the duplication by pulling the path to the encodings file in to a variable instead?
Simon Fraser (smfr)
Comment 3
2014-01-10 16:54:33 PST
http://trac.webkit.org/changeset/161698
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug