Bug 126789 – [Mac] [Windows] Stop scheduling network requests in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Alexey Proskuryakov]

We already have the code to set request priorities, can just pass the job down on CFNetwork.

<rdar://problem/15114727>

[Alexey Proskuryakov]

Created attachment 220903 [details]
proposed patch

This patch will fail to build, because it needs WebKitSystemInterface changes. Please review anyway.

[Build Bot]

Comment on attachment 220903 [details]
proposed patch

Attachment 220903 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4533502531862528

[Build Bot]

Comment on attachment 220903 [details]
proposed patch

Attachment 220903 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4673190437584896

[Sam Weinig]

Comment on attachment 220903 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220903&action=review

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:178
> +        // Synchronous requests should not be subject to regular connection count limit to avoid deadlocks.

A bit more about these deadlocks would be useful here.

> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:45
> +    // FIXME: What is the purpose of these assignments? WebKit normally uses upper case "WK" functions directly.
>      wkInitializeMaximumHTTPConnectionCountPerHost = WKInitializeMaximumHTTPConnectionCountPerHost;
> -    wkSetHTTPPipeliningMaximumPriority = WKSetHTTPPipeliningMaximumPriority;
> -    wkSetHTTPPipeliningMinimumFastLanePriority = WKSetHTTPPipeliningMinimumFastLanePriority;
> +    wkSetHTTPRequestMaximumPriority = WKSetHTTPRequestMaximumPriority;
> +    wkSetHTTPRequestMinimumFastLanePriority = WKSetHTTPRequestMinimumFastLanePriority;

I'd just go ahead and remove them rather than add the FIXME.

> Source/WebKit2/UIProcess/API/C/WKContext.cpp:-63
> -extern "C" {
> -// For binary compatibility with Safari 5.1. Should be removed eventually.
> -WK_EXPORT void _WKContextSetAdditionalPluginsDirectory(WKContextRef context, WKStringRef pluginsDirectory);
> -WK_EXPORT void _WKContextRegisterURLSchemeAsEmptyDocument(WKContextRef context, WKStringRef urlScheme);
> -WK_EXPORT void _WKContextSetAlwaysUsesComplexTextCodePath(WKContextRef context, bool alwaysUseComplexTextCodePath);
> -WK_EXPORT void _WKContextSetHTTPPipeliningEnabled(WKContextRef context, bool enabled);

I would save this for a different patch.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r161796>.