WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126784
Web Inspector: Remove unimplemented or static ScriptDebugServer features
https://bugs.webkit.org/show_bug.cgi?id=126784
Summary
Web Inspector: Remove unimplemented or static ScriptDebugServer features
Joseph Pecoraro
Reported
2014-01-10 14:43:16 PST
In our inspector frontend these methods are all unused and in the backend they are unimplemented. Lets remove them. These functions were needed for the following features / reasons: • differences between v8 and JSC • detecting if features were available or not "canFoo*" • live script editing • snippet support • script preprocessor, a script that can analyze any Script evaluated in the JS engine We can implement these ourselves if/when we decide to add such features. Right now all of this code is stale / unimplemented.
Attachments
[PATCH] Proposed Fix
(49.17 KB, patch)
2014-01-10 14:47 PST
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2014-01-10 14:47:01 PST
Created
attachment 220891
[details]
[PATCH] Proposed Fix Note that I leave iOS 7's PageAgent.reload with the optional scriptPreprocessor parameter. Unlike other times where we retroactively delete whole commands from Legacy Inspector.json files, this is not deleting a whole command, and so I think we should be be explicit about what the backend expected from that method.
Radar WebKit Bug Importer
Comment 2
2014-01-10 15:33:44 PST
<
rdar://problem/15796797
>
WebKit Commit Bot
Comment 3
2014-01-10 15:52:13 PST
Comment on
attachment 220891
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 220891 Committed
r161691
: <
http://trac.webkit.org/changeset/161691
>
WebKit Commit Bot
Comment 4
2014-01-10 15:52:15 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug