As I understand it cc and c++ are the default C and C++ system compilers. So as the final fall though the script should use them instead of hoping gcc might be installed. This was found because on FreeBSD 10 we don't have gcc anymore in base on the x86* archs.
Created attachment 220877 [details] Switch to system default compiler
Please set r? flag if you would like to ask for review.
Comment on attachment 220877 [details] Switch to system default compiler View in context: https://bugs.webkit.org/attachment.cgi?id=220877&action=review > ChangeLog:4 > + Use system default compiler instead of gcc, as final fall through. > + https://bugs.webkit.org/show_bug.cgi?id=126773 Please revert this change to root ChangeLog, updating Source/WebCore/ChangeLog is sufficient.
Created attachment 221281 [details] Drop root changelog entry, set review flag Is there a general rule for when to update the root Changelog or not?
> Is there a general rule for when to update the root Changelog or not? yes, when Tools/Scripts/prepare-ChangeLog automatically does it ;)
Comment on attachment 221281 [details] Drop root changelog entry, set review flag View in context: https://bugs.webkit.org/attachment.cgi?id=221281&action=review > Source/WebCore/dom/make_names.pl:73 > + $gccLocation = "/usr/bin/cc"; Should rename the variable one day.
Comment on attachment 221281 [details] Drop root changelog entry, set review flag Clearing flags on attachment: 221281 Committed r163534: <http://trac.webkit.org/changeset/163534>
All reviewed patches have been landed. Closing bug.