Bug 126769 - [EFL][WK2] Make API tests work again
Summary: [EFL][WK2] Make API tests work again
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Correia (qrwteyrutiyoup)
Depends on:
Reported: 2014-01-10 11:55 PST by Sergio Correia (qrwteyrutiyoup)
Modified: 2014-01-12 20:11 PST (History)
6 users (show)

See Also:

Patch (7.62 KB, patch)
2014-01-10 11:58 PST, Sergio Correia (qrwteyrutiyoup)
no flags Details | Formatted Diff | Diff
v2 with Gyuyoung remakrs (7.52 KB, patch)
2014-01-12 18:00 PST, Sergio Correia (qrwteyrutiyoup)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Correia (qrwteyrutiyoup) 2014-01-10 11:55:57 PST
[EFL][WK2] Make API tests work again
Comment 1 Sergio Correia (qrwteyrutiyoup) 2014-01-10 11:56:53 PST
The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
[E]WebKit2, respectively, and this causes problems because the logic to find
where WebProcess is to look in the same directory of the running process and
then proceed to use LIBEXECDIR (typically /usr/loca/bin).

This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
Gtk port, which allows us to look for WebProcess initially in this directory,
if it's defined.
Comment 2 Sergio Correia (qrwteyrutiyoup) 2014-01-10 11:58:33 PST
Created attachment 220870 [details]
Comment 3 Gyuyoung Kim 2014-01-11 03:07:11 PST
Comment on attachment 220870 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=220870&action=review

Looks make sense. Please land after fixing my comments.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:44
> +        executablePath = WebCore::pathByAppendingComponent(String(execDirectory), processName);

String(execDirectory) -> String::fromUTF8(execDirectory) ?

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:59
> +        executablePath = WebCore::pathByAppendingComponent(String(executablePathPtr), processName);

ditto ?

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:66
> +        LOG_ERROR("Failed to locate the path of '%s'.", processName);

Don't you need to return nullptr ?
Comment 4 Sergio Correia (qrwteyrutiyoup) 2014-01-12 18:00:13 PST
Created attachment 220994 [details]
v2 with Gyuyoung remakrs
Comment 5 Gyuyoung Kim 2014-01-12 19:36:44 PST
Comment on attachment 220994 [details]
v2 with Gyuyoung remakrs

Comment 6 Gyuyoung Kim 2014-01-12 19:37:26 PST
If you already got r+, then, you don't need to get r+ again.
Comment 7 WebKit Commit Bot 2014-01-12 20:11:19 PST
Comment on attachment 220994 [details]
v2 with Gyuyoung remakrs

Clearing flags on attachment: 220994

Committed r161857: <http://trac.webkit.org/changeset/161857>
Comment 8 WebKit Commit Bot 2014-01-12 20:11:23 PST
All reviewed patches have been landed.  Closing bug.