Bug 126767 - Web Inspector: Clean/fix the stdout formatting of console messages
Summary: Web Inspector: Clean/fix the stdout formatting of console messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-10 11:18 PST by Timothy Hatcher
Modified: 2014-01-10 14:12 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.58 KB, patch)
2014-01-10 11:23 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2014-01-10 11:56 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch for landing (5.56 KB, patch)
2014-01-10 13:54 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-10 11:18:18 PST
* Fix URLs not printing line numbers unless column number is > 0.
* Clean up how console.trace outputs.
* Print URL, line and column for each trace call frame.
* Print (unknown) for anonymous and native code call frames.
Comment 1 Radar WebKit Bug Importer 2014-01-10 11:19:06 PST
<rdar://problem/15794034>
Comment 2 Timothy Hatcher 2014-01-10 11:23:43 PST
Created attachment 220867 [details]
Patch
Comment 3 WebKit Commit Bot 2014-01-10 11:25:06 PST
Attachment 220867 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:5:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:6:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2014-01-10 11:40:01 PST
Comment on attachment 220867 [details]
Patch

r=me!
Comment 5 Timothy Hatcher 2014-01-10 11:56:21 PST
Created attachment 220868 [details]
Patch
Comment 6 WebKit Commit Bot 2014-01-10 11:58:16 PST
Attachment 220868 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:5:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:6:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-01-10 13:42:03 PST
Comment on attachment 220868 [details]
Patch

Rejecting attachment 220868 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 220868, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6050564169269248
Comment 8 Timothy Hatcher 2014-01-10 13:54:52 PST
Created attachment 220884 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2014-01-10 13:55:35 PST
Attachment 220884 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:5:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:6:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2014-01-10 14:12:20 PST
Comment on attachment 220884 [details]
Patch for landing

Clearing flags on attachment: 220884

Committed r161678: <http://trac.webkit.org/changeset/161678>
Comment 11 WebKit Commit Bot 2014-01-10 14:12:24 PST
All reviewed patches have been landed.  Closing bug.