RESOLVED FIXED 126767
Web Inspector: Clean/fix the stdout formatting of console messages 
https://bugs.webkit.org/show_bug.cgi?id=126767
Summary Web Inspector: Clean/fix the stdout formatting of console messages
Timothy Hatcher
Reported 2014-01-10 11:18:18 PST
* Fix URLs not printing line numbers unless column number is > 0. * Clean up how console.trace outputs. * Print URL, line and column for each trace call frame. * Print (unknown) for anonymous and native code call frames.
Attachments
Patch (5.58 KB, patch)
2014-01-10 11:23 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2014-01-10 11:56 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.56 KB, patch)
2014-01-10 13:54 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-10 11:19:06 PST
<rdar://problem/15794034>
Timothy Hatcher
Comment 2 2014-01-10 11:23:43 PST
Created attachment 220867 [details] Patch
WebKit Commit Bot
Comment 3 2014-01-10 11:25:06 PST
Attachment 220867 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:5: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:6: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2014-01-10 11:40:01 PST
Comment on attachment 220867 [details] Patch r=me!
Timothy Hatcher
Comment 5 2014-01-10 11:56:21 PST
Created attachment 220868 [details] Patch
WebKit Commit Bot
Comment 6 2014-01-10 11:58:16 PST
Attachment 220868 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:5: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:6: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2014-01-10 13:42:03 PST
Comment on attachment 220868 [details] Patch Rejecting attachment 220868 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 220868, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6050564169269248
Timothy Hatcher
Comment 8 2014-01-10 13:54:52 PST
Created attachment 220884 [details] Patch for landing
WebKit Commit Bot
Comment 9 2014-01-10 13:55:35 PST
Attachment 220884 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:5: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:6: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2014-01-10 14:12:20 PST
Comment on attachment 220884 [details] Patch for landing Clearing flags on attachment: 220884 Committed r161678: <http://trac.webkit.org/changeset/161678>
WebKit Commit Bot
Comment 11 2014-01-10 14:12:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.