WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126765
Web Inspector: Exception in WebInspector.Color trying to concat a function
https://bugs.webkit.org/show_bug.cgi?id=126765
Summary
Web Inspector: Exception in WebInspector.Color trying to concat a function
Timothy Hatcher
Reported
2014-01-10 10:57:19 PST
Viewing source with the token "constructor" will cause an exception in WebInspector.Color because ("constructor" in WebInspector.Color.Nicknames) will be true.
Attachments
Patch
(2.08 KB, patch)
2014-01-10 11:00 PST
,
Timothy Hatcher
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-01-10 10:58:14 PST
<
rdar://problem/15793773
>
Timothy Hatcher
Comment 2
2014-01-10 11:00:01 PST
Created
attachment 220863
[details]
Patch
Joseph Pecoraro
Comment 3
2014-01-10 11:10:14 PST
Comment on
attachment 220863
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220863&action=review
r=me
> Source/WebInspectorUI/ChangeLog:10 > + (WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
Typo: hasOwnPrperty
WebKit Commit Bot
Comment 4
2014-01-10 14:02:13 PST
Comment on
attachment 220863
[details]
Patch Clearing flags on attachment: 220863 Committed
r161674
: <
http://trac.webkit.org/changeset/161674
>
WebKit Commit Bot
Comment 5
2014-01-10 14:02:16 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug