Bug 126765 - Web Inspector: Exception in WebInspector.Color trying to concat a function
Summary: Web Inspector: Exception in WebInspector.Color trying to concat a function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-10 10:57 PST by Timothy Hatcher
Modified: 2014-01-10 14:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2014-01-10 11:00 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-10 10:57:19 PST
Viewing source with the token "constructor" will cause an exception in WebInspector.Color because ("constructor" in WebInspector.Color.Nicknames) will be true.
Comment 1 Radar WebKit Bug Importer 2014-01-10 10:58:14 PST
<rdar://problem/15793773>
Comment 2 Timothy Hatcher 2014-01-10 11:00:01 PST
Created attachment 220863 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-10 11:10:14 PST
Comment on attachment 220863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220863&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        (WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.

Typo: hasOwnPrperty
Comment 4 WebKit Commit Bot 2014-01-10 14:02:13 PST
Comment on attachment 220863 [details]
Patch

Clearing flags on attachment: 220863

Committed r161674: <http://trac.webkit.org/changeset/161674>
Comment 5 WebKit Commit Bot 2014-01-10 14:02:16 PST
All reviewed patches have been landed.  Closing bug.