Bug 126753 - DOMWindow::showModalDialog should use std::function
Summary: DOMWindow::showModalDialog should use std::function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-10 08:51 PST by Anders Carlsson
Modified: 2014-01-10 09:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.42 KB, patch)
2014-01-10 08:52 PST, Anders Carlsson 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-10 08:51:04 PST 
DOMWindow::showModalDialog should use std::function
Comment 1 Anders Carlsson 2014-01-10 08:52:04 PST 
Created attachment 220847 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-10 08:54:27 PST 
Attachment 220847 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/page/DOMWindow.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.h:445:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2015:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2122:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-01-10 09:03:54 PST 
Committed r161639: <http://trac.webkit.org/changeset/161639>