RESOLVED FIXED126750
[WinCairo] Crash when rendering (in pixman dll) 
https://bugs.webkit.org/show_bug.cgi?id=126750
Summary [WinCairo] Crash when rendering (in pixman dll)
peavo
Reported 2014-01-10 07:27:33 PST
I'm getting a consistent crash in libpixman-1.0.dll when rendering. The libpixman-1.0.dll is from the gstreamer installation, and we should not be using that in our rendering. It is used because we link with cairo.lib, but since there is also a cairo.lib in the gstreamer installation, we link with the wrong cairo.lib, and when executing, loads the wrong cairo dll (from the gstreamer installation). We need to make sure the WebKitLibraries path comes before the gstreamer lib path, so we pick up the correct cairo.lib. This is the message, and stack trace of the crash: First-chance exception at 0x653893BC (libpixman-1-0.dll) in WinLauncher.exe: 0xC0000005: Access violation reading location 0x00000000. libpixman-1-0.dll!653893bc() Unknown [Frames below may be incorrect and/or missing, no symbols loaded for libpixman-1-0.dll] libpixman-1-0.dll!6534a8a0() Unknown
Attachments
Patch (2.70 KB, patch)
2014-01-10 07:39 PST, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-01-10 07:39:30 PST
Created attachment 220845 [details] Patch
Brent Fulgham
Comment 2 2014-01-10 08:45:30 PST
Comment on attachment 220845 [details] Patch r=me
Brent Fulgham
Comment 3 2014-01-10 08:47:07 PST
It would probably make sense to have a single bundle of stuff that included the GStreamer and Cairo libraries all together, rather than the current situation of WebKit-built libxml/pixmal/cairo/etc plus an external bundle of stuff that includes similar libraries.
WebKit Commit Bot
Comment 4 2014-01-10 09:13:22 PST
Comment on attachment 220845 [details] Patch Clearing flags on attachment: 220845 Committed r161640: <http://trac.webkit.org/changeset/161640>
WebKit Commit Bot
Comment 5 2014-01-10 09:13:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.