Bug 126748 - Fix building with SVG support disabled
Summary: Fix building with SVG support disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-10 07:13 PST by Adrian Perez
Modified: 2014-01-10 14:53 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2014-01-10 07:13 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2014-01-10 07:15 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2014-01-10 07:13:24 PST
Created attachment 220840 [details]
Patch

Building with SVG disabled fails due to a stray closing brace inside the
#if ENABLED(SVG) block. Moving the brace fixes the compilation failure.
Comment 1 Adrian Perez 2014-01-10 07:15:22 PST
Created attachment 220842 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-01-10 09:04:24 PST
Comment on attachment 220842 [details]
Patch

LGTM, r=me. It is a correct fix after r161589.
Comment 3 WebKit Commit Bot 2014-01-10 13:10:18 PST
Comment on attachment 220842 [details]
Patch

Rejecting attachment 220842 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 220842, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/FontFastPath.cpp
Hunk #1 FAILED at 228.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/FontFastPath.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Csaba Osztrogon\xe1c']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5006518286024704
Comment 4 Manuel Rego Casasnovas 2014-01-10 14:53:25 PST
It was already fixed at http://trac.webkit.org/changeset/161652