Bug 126741 - [GTK] Fix return value of WebKitDownload::created-destination
Summary: [GTK] Fix return value of WebKitDownload::created-destination
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-01-10 01:27 PST by Carlos Garcia Campos
Modified: 2014-01-12 00:41 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.60 KB, patch)
2014-01-10 01:30 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-01-10 01:27:30 PST
Fortunately this is not an API break because it was actually unused, if anybody is using a boolean callback it will still work. I guess it's another copy-paste error :-(
Comment 1 Carlos Garcia Campos 2014-01-10 01:30:39 PST
Created attachment 220820 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-10 01:33:31 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-01-12 00:41:52 PST
Committed r161805: <http://trac.webkit.org/changeset/161805>