RESOLVED FIXED 126736
[EFL][WK2] Add APIs for setting and getting the default text encoding name 
https://bugs.webkit.org/show_bug.cgi?id=126736
Summary [EFL][WK2] Add APIs for setting and getting the default text encoding name
Jinwoo Song
Reported 2014-01-09 22:22:15 PST
Browser needs a capability to set and get the default text encoding name.
Attachments
Patch (4.98 KB, patch)
2014-01-09 22:33 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2014-01-09 22:54 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (5.05 KB, patch)
2014-01-09 23:09 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-01-09 22:33:47 PST
Created attachment 220803 [details] Patch
Ryuan Choi
Comment 2 2014-01-09 22:47:08 PST
Comment on attachment 220803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220803&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:190 > + settings->preferences()->setDefaultTextEncodingName(String(encoding)); Maybe String::fromUTF8 ? > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:259 > + * @param settings settings object to query default text encoding nae name
Gyuyoung Kim
Comment 3 2014-01-09 22:48:10 PST
Comment on attachment 220803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220803&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:259 > + * @param settings settings object to query default text encoding nae nae -> name ? And, you need to add "The string is guaranteed to be stringshared." comment as well.
Jinwoo Song
Comment 4 2014-01-09 22:54:14 PST
Created attachment 220804 [details] Patch
Jinwoo Song
Comment 5 2014-01-09 23:09:48 PST
Created attachment 220806 [details] Patch Applied comments from Ryuan and Gyuyoung.
Gyuyoung Kim
Comment 6 2014-01-09 23:14:26 PST
Comment on attachment 220806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220806&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:179 > + EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0); Can't we use nullptr instead of 0 ?
Jinwoo Song
Comment 7 2014-01-09 23:28:39 PST
Comment on attachment 220806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220806&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:179 >> + EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0); > > Can't we use nullptr instead of 0 ? We may replace 0 with nullptr including other cases in another bug.
WebKit Commit Bot
Comment 8 2014-01-09 23:56:40 PST
Comment on attachment 220806 [details] Patch Clearing flags on attachment: 220806 Committed r161624: <http://trac.webkit.org/changeset/161624>
WebKit Commit Bot
Comment 9 2014-01-09 23:56:42 PST
All reviewed patches have been landed. Closing bug.
Ryuan Choi
Comment 10 2014-02-07 22:41:14 PST
*** Bug 100225 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.