Browser needs a capability to set and get the default text encoding name.
Created attachment 220803 [details] Patch
Comment on attachment 220803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220803&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:190 > + settings->preferences()->setDefaultTextEncodingName(String(encoding)); Maybe String::fromUTF8 ? > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:259 > + * @param settings settings object to query default text encoding nae name
Comment on attachment 220803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220803&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:259 > + * @param settings settings object to query default text encoding nae nae -> name ? And, you need to add "The string is guaranteed to be stringshared." comment as well.
Created attachment 220804 [details] Patch
Created attachment 220806 [details] Patch Applied comments from Ryuan and Gyuyoung.
Comment on attachment 220806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220806&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:179 > + EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0); Can't we use nullptr instead of 0 ?
Comment on attachment 220806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220806&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:179 >> + EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0); > > Can't we use nullptr instead of 0 ? We may replace 0 with nullptr including other cases in another bug.
Comment on attachment 220806 [details] Patch Clearing flags on attachment: 220806 Committed r161624: <http://trac.webkit.org/changeset/161624>
All reviewed patches have been landed. Closing bug.
*** Bug 100225 has been marked as a duplicate of this bug. ***