Bug 126735 - Fix a build break on EFL debug build
Summary: Fix a build break on EFL debug build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 21:53 PST by Gyuyoung Kim
Modified: 2014-01-09 22:18 PST (History)
0 users

See Also:


Attachments
Patch (1.30 KB, patch)
2014-01-09 21:57 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-01-09 21:53:02 PST
There is a build error when compiling EFL debug build.


[ 14%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o
/home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp: In member function ‘void WebCore::ThreadTimers::sharedTimerFiredInternal()’:
/home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp:112:5: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
Comment 1 Gyuyoung Kim 2014-01-09 21:57:36 PST
Created attachment 220801 [details]
Patch
Comment 2 Anders Carlsson 2014-01-09 22:10:15 PST
Comment on attachment 220801 [details]
Patch

Patch looks good since it doesn't change the meaning, but this makes me wonder what the assertion is there for at all!
Comment 3 Gyuyoung Kim 2014-01-09 22:18:21 PST
Comment on attachment 220801 [details]
Patch

Clearing flags on attachment: 220801

Committed r161621: <http://trac.webkit.org/changeset/161621>
Comment 4 Gyuyoung Kim 2014-01-09 22:18:27 PST
All reviewed patches have been landed.  Closing bug.