Bug 126726 - Remove Blackberry and QNX bits from WTF
Summary: Remove Blackberry and QNX bits from WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 126715
  Show dependency tree / graph
 
Reported: 2014-01-09 16:14 PST by Anders Carlsson
Modified: 2014-01-09 16:27 PST (History)
1 user (show)

See Also:

Attachments
Patch (24.29 KB, patch)
2014-01-09 16:16 PST, Anders Carlsson 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-09 16:14:48 PST 
Remove Blackberry and QNX bits from WTF
Comment 1 Anders Carlsson 2014-01-09 16:16:59 PST 
Created attachment 220786 [details]
Patch
Comment 2 Benjamin Poulain 2014-01-09 16:20:09 PST 
Comment on attachment 220786 [details]
Patch

lgtm
Comment 3 WebKit Commit Bot 2014-01-09 16:20:15 PST 
Attachment 220786 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Atomics.h', u'Source/WTF/wtf/CurrentTime.cpp', u'Source/WTF/wtf/DateMath.cpp', u'Source/WTF/wtf/DisallowCType.h', u'Source/WTF/wtf/FeatureDefines.h', u'Source/WTF/wtf/InlineASM.h', u'Source/WTF/wtf/MathExtras.h', u'Source/WTF/wtf/NumberOfCores.cpp', u'Source/WTF/wtf/OSAllocatorPosix.cpp', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/PlatformBlackBerry.cmake', u'Source/WTF/wtf/RAMSize.cpp', u'Source/WTF/wtf/StackBounds.cpp', u'Source/WTF/wtf/ThreadingPthreads.cpp', u'Source/WTF/wtf/blackberry/MainThreadBlackBerry.cpp', u'Source/WTF/wtf/blackberry/RunLoopBlackBerry.cpp', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', '--commit-queue']" exit_code: 1
ERROR: Source/WTF/wtf/InlineASM.h:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-01-09 16:27:07 PST 
Committed r161601: <http://trac.webkit.org/changeset/161601>