RESOLVED FIXED 126719
[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings 
https://bugs.webkit.org/show_bug.cgi?id=126719
Summary [CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveV...
Bear Travis
Reported 2014-01-09 14:03:04 PST
The conversion between CSSPrimitiveValues (eg CSSValueMarginBox) and LayoutBoxes (MarginBox) should happen in CSSPrimitiveValueMappings rather than in BasicShapeFunctions, as that's the standard place to put such conversions.
Attachments
Initial Patch (9.33 KB, patch)
2014-01-09 14:06 PST, Bear Travis 		krit: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Updated Patch (8.94 KB, patch)
2014-01-11 09:50 PST, Bear Travis 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Updated Patch (9.26 KB, patch)
2014-01-13 11:24 PST, Bear Travis 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Adding reviewer to changelogs (8.96 KB, patch)
2014-01-14 13:01 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2014-01-09 14:06:29 PST
Created attachment 220767 [details] Initial Patch
Dirk Schulze
Comment 2 2014-01-10 00:00:29 PST
Comment on attachment 220767 [details] Initial Patch r=me
WebKit Commit Bot
Comment 3 2014-01-10 11:22:06 PST
Comment on attachment 220767 [details] Initial Patch Rejecting attachment 220767 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 220767, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ubmit return self.open(self.click(*args, **kwds)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-queues.appspot.com/results/6327271866499072
Bear Travis
Comment 4 2014-01-11 09:50:23 PST
Created attachment 220934 [details] Updated Patch
EFL EWS Bot
Comment 5 2014-01-11 10:04:28 PST
Comment on attachment 220934 [details] Updated Patch Attachment 220934 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4746130793431040
Bear Travis
Comment 6 2014-01-13 11:24:25 PST
Created attachment 221066 [details] Updated Patch
WebKit Commit Bot
Comment 7 2014-01-14 11:50:47 PST
Comment on attachment 221066 [details] Updated Patch Rejecting attachment 221066 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 221066, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5644115442139136
Bear Travis
Comment 8 2014-01-14 13:01:43 PST
Created attachment 221190 [details] Adding reviewer to changelogs
WebKit Commit Bot
Comment 9 2014-01-14 13:37:54 PST
Comment on attachment 221190 [details] Adding reviewer to changelogs Clearing flags on attachment: 221190 Committed r162001: <http://trac.webkit.org/changeset/162001>
WebKit Commit Bot
Comment 10 2014-01-14 13:37:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.