Bug 126717 - Web Inspector: Consolidate developerExtrasEnabled to just InspectorEnvironment
Summary: Web Inspector: Consolidate developerExtrasEnabled to just InspectorEnvironment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-09 13:49 PST by Joseph Pecoraro
Modified: 2014-01-09 14:49 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (19.73 KB, patch)
2014-01-09 13:51 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-09 13:49:33 PST 
Currently there are multiple inspector agents (Inspector, Console) that have developerExtrasEnabled checks. They all route to InspectorEnvironment (*InspectorController), so just use the InspectorEnvironment call directly. Note, all WebCore agents have InstrumentingAgents, so put InspectorEnvironment on InstrumentingAgents to make it available to all agents.
Comment 1 Radar WebKit Bug Importer 2014-01-09 13:51:11 PST 
<rdar://problem/15785810>
Comment 2 Joseph Pecoraro 2014-01-09 13:51:21 PST 
Created attachment 220766 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-01-09 14:49:23 PST 
Comment on attachment 220766 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 220766

Committed r161588: <http://trac.webkit.org/changeset/161588>
Comment 4 WebKit Commit Bot 2014-01-09 14:49:25 PST 
All reviewed patches have been landed.  Closing bug.