WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126714
Replace ElementIteratorAdapter find() with beginAt()
https://bugs.webkit.org/show_bug.cgi?id=126714
Summary
Replace ElementIteratorAdapter find() with beginAt()
Antti Koivisto
Reported
2014-01-09 13:00:14 PST
It makes more sense for what it does.
Attachments
patch
(9.14 KB, patch)
2014-01-09 13:07 PST
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2014-01-09 13:07:57 PST
Created
attachment 220763
[details]
patch
Andreas Kling
Comment 2
2014-01-09 13:13:44 PST
Comment on
attachment 220763
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220763&action=review
Nice :)
> Source/WebCore/html/HTMLFormElement.cpp:508 > + if (!associatedHTMLElement.isDescendantOf(this)) > + return currentAssociatedElementsAfterIndex;
isDescendantOf signature is rather 2012 :|
Antti Koivisto
Comment 3
2014-01-09 14:06:46 PST
https://trac.webkit.org/r161583
Darin Adler
Comment 4
2014-01-10 12:59:40 PST
Thanks. Better than I had hoped for!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug