Bug 126714 - Replace ElementIteratorAdapter find() with beginAt()
Summary: Replace ElementIteratorAdapter find() with beginAt()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 13:00 PST by Antti Koivisto
Modified: 2014-01-10 12:59 PST (History)
1 user (show)

See Also:

Attachments
patch (9.14 KB, patch)
2014-01-09 13:07 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-09 13:00:14 PST 
It makes more sense for what it does.
Comment 1 Antti Koivisto 2014-01-09 13:07:57 PST 
Created attachment 220763 [details]
patch
Comment 2 Andreas Kling 2014-01-09 13:13:44 PST 
Comment on attachment 220763 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220763&action=review

Nice :)

> Source/WebCore/html/HTMLFormElement.cpp:508
> +    if (!associatedHTMLElement.isDescendantOf(this))
> +        return currentAssociatedElementsAfterIndex;

isDescendantOf signature is rather 2012 :|
Comment 3 Antti Koivisto 2014-01-09 14:06:46 PST 
https://trac.webkit.org/r161583
Comment 4 Darin Adler 2014-01-10 12:59:40 PST 
Thanks. Better than I had hoped for!