Bug 126705 – [Mac] Scrubbing performance of HD content with software decoding is poor.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] Scrubbing performance of HD content with software decoding is poor.

[Jer Noble]

Created attachment 220761 [details]
Patch

[Jer Noble]

<rdar://problem/14652501>

[Eric Carlson]

Comment on attachment 220761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220761&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:277
> +        m_pendingSeek = std::bind(&MediaPlayerPrivateAVFoundation::seekWithTolerance, this, time, negativeTolerance, positiveTolerance);

Can you just use a C++11 lambda here (https://bugs.webkit.org/show_bug.cgi?id=126639 implies we are going away from bind())?

[Build Bot]

Comment on attachment 220761 [details]
Patch

Attachment 220761 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5307652670226432

[Build Bot]

Comment on attachment 220761 [details]
Patch

Attachment 220761 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6024591159853056

[Jer Noble]

Created attachment 220764 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 220764 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:277:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 220764 [details]
Patch for landing

Attachment 220764 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5513936057139200

New failing tests:
media/video-seek-multiple.html
media/video-fast-seek.html

[Build Bot]

Created attachment 220770 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 220764 [details]
Patch for landing

Attachment 220764 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6134343680393216

New failing tests:
media/video-seek-multiple.html
media/video-fast-seek.html

[Build Bot]

Created attachment 220774 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Jer Noble]

Created attachment 220776 [details]
Patch for landing

Clean up some unused ivars and only send a timeupdate event when all the seeks are complete.

[WebKit Commit Bot]

Attachment 220776 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:276:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Committed r161613: <http://trac.webkit.org/changeset/161613>