Bug 126700 - Disconnect child frames iteratively
Summary: Disconnect child frames iteratively
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 08:26 PST by Antti Koivisto
Modified: 2014-01-09 12:07 PST (History)
3 users (show)

See Also:


Attachments
patch (8.65 KB, patch)
2014-01-09 08:46 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-09 08:26:10 PST
Get rid of the odd ChildFrameDisconnector factoring too.
Comment 1 Antti Koivisto 2014-01-09 08:46:11 PST
Created attachment 220743 [details]
patch
Comment 2 Andreas Kling 2014-01-09 08:55:01 PST
Comment on attachment 220743 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220743&action=review

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:171
> +        HTMLFrameOwnerElement& owner = frameOwners[i].get();

I'd use auto& here, since the type is repeated.
Comment 3 Antti Koivisto 2014-01-09 12:07:54 PST
ttps://trac.webkit.org/r161567