Bug 126699 - Regression: failing RegExp tests on 32 bit architectures.
Summary: Regression: failing RegExp tests on 32 bit architectures.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 08:01 PST by Balazs Kilvady
Modified: 2014-01-09 10:42 PST (History)
12 users (show)

See Also:

Attachments
proposed patch. (2.65 KB, patch)
2014-01-09 08:11 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kilvady 2014-01-09 08:01:24 PST 
setRegExpConstructorInput and setRegExpConstructorMultiline functions are defined with (ExecState*, JSObject*, JSValue) parameters but are called with (ExecState*, EncodedJSValue, EncodedJSValue) parameters:

(gdb) p entry->m_u.property.put
$6 = (JSC::PutFunction) 0x7791feac <JSC::setRegExpConstructorMultiline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue)>
(gdb) ptype entry->m_u.property.put
type = void (*)(JSC::ExecState *, JSC::EncodedJSValue, JSC::EncodedJSValue)
Comment 1 Balazs Kilvady 2014-01-09 08:11:26 PST 
Created attachment 220737 [details]
proposed patch.
Comment 2 Oliver Hunt 2014-01-09 10:29:20 PST 
Comment on attachment 220737 [details]
proposed patch.

whoops, sorry
Comment 3 WebKit Commit Bot 2014-01-09 10:42:24 PST 
Comment on attachment 220737 [details]
proposed patch.

Clearing flags on attachment: 220737

Committed r161562: <http://trac.webkit.org/changeset/161562>
Comment 4 WebKit Commit Bot 2014-01-09 10:42:26 PST 
All reviewed patches have been landed.  Closing bug.