Bug 126695 - Possible crash in ApplicationCache::removeResource
Summary: Possible crash in ApplicationCache::removeResource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 07:09 PST by Piotr Grad
Modified: 2014-01-10 13:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2014-01-09 07:13 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
Patch (1.26 KB, patch)
2014-01-09 14:15 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Grad 2014-01-09 07:09:28 PST 
"Iterator it" variable is used after is removed. Working on patch, will be proposed soon.
Comment 1 Piotr Grad 2014-01-09 07:13:36 PST 
Created attachment 220730 [details]
Patch
Comment 2 Piotr Grad 2014-01-09 08:36:39 PST 
Comment on attachment 220730 [details]
Patch

mac-wk2 is not passing also with other attachments with same output.
Comment 3 Alexey Proskuryakov 2014-01-09 09:16:43 PST 
Comment on attachment 220730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests.

This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think.
Comment 4 Piotr Grad 2014-01-09 14:15:51 PST 
Created attachment 220768 [details]
Patch
Comment 5 WebKit Commit Bot 2014-01-10 13:04:50 PST 
Comment on attachment 220730 [details]
Patch

Clearing flags on attachment: 220730

Committed r161665: <http://trac.webkit.org/changeset/161665>
Comment 6 WebKit Commit Bot 2014-01-10 13:04:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2014-01-10 13:14:40 PST 
Comment on attachment 220730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests.
> 
> This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think.

Given that our iterators are checked, I think we could indeed make a test for this. If we can get this code to run, it should assert in a debug build. This fix should not have gone in without a test!