Bug 126693 - [GTK] Fails to build if configure is run with its absolute path
Summary: [GTK] Fails to build if configure is run with its absolute path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 06:44 PST by Alberto Garcia
Modified: 2014-02-12 05:16 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2014-01-09 06:47 PST, Alberto Garcia
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2014-01-09 06:44:25 PST
There's a couple of links from the build dir to the webkit 2 headers
in the source dir that are created like this:

   ln -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@
   ln -s -f ${shell pwd}/$(WebKit2)/WebProcess/InjectedBundle/API/gtk $@

Problem is, that works if $(WebKit2) is a relative path, e.g if we
create the build dir inside the webkit source tree and run ../configure:

   ln -s -f /tmp/webkit/build/../Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2
   ln -s -f /tmp/webkit/build/../Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2

However if we use an absolute path (/tmp/webkit/configure in this
example) we get a broken link:

   ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2
   ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2

A quick fix is to replace the makefile recipe with something like this:

   ln -s -f ${shell cd $(WebKit2)/UIProcess/API/gtk && pwd} $@
   ln -s -f ${shell cd $(WebKit2)/WebProcess/InjectedBundle/API/gtk && pwd} $@
Comment 1 Alberto Garcia 2014-01-09 06:47:48 PST
Created attachment 220725 [details]
Patch
Comment 2 Alberto Garcia 2014-02-12 05:16:17 PST
Committed r163956: <http://trac.webkit.org/changeset/163956>