RESOLVED FIXED 126693
[GTK] Fails to build if configure is run with its absolute path
https://bugs.webkit.org/show_bug.cgi?id=126693
Summary [GTK] Fails to build if configure is run with its absolute path
Alberto Garcia
Reported 2014-01-09 06:44:25 PST
There's a couple of links from the build dir to the webkit 2 headers in the source dir that are created like this: ln -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@ ln -s -f ${shell pwd}/$(WebKit2)/WebProcess/InjectedBundle/API/gtk $@ Problem is, that works if $(WebKit2) is a relative path, e.g if we create the build dir inside the webkit source tree and run ../configure: ln -s -f /tmp/webkit/build/../Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2 ln -s -f /tmp/webkit/build/../Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2 However if we use an absolute path (/tmp/webkit/configure in this example) we get a broken link: ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2 ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2 A quick fix is to replace the makefile recipe with something like this: ln -s -f ${shell cd $(WebKit2)/UIProcess/API/gtk && pwd} $@ ln -s -f ${shell cd $(WebKit2)/WebProcess/InjectedBundle/API/gtk && pwd} $@
Attachments
Patch (1.53 KB, patch)
2014-01-09 06:47 PST, Alberto Garcia
gustavo: review+
Alberto Garcia
Comment 1 2014-01-09 06:47:48 PST
Alberto Garcia
Comment 2 2014-02-12 05:16:17 PST
Note You need to log in before you can comment on or make changes to this bug.